> On 一月 14, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 1843-1844
> > <https://reviews.apache.org/r/39628/diff/3/?file=1196600#file1196600line1843>
> >
> >     How about
> >     
> >     // This test checks that if a framework suppresses offers, disconnects 
> > and reconnects again,
> >     // it will starting receiving resource offers again.

Minor change: // it will `start` receiving resource offers again.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------


On 一月 14, 2016, 9:53 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
> 
> (Updated 一月 14, 2016, 9:53 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3802
>     https://issues.apache.org/jira/browse/MESOS-3802
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleared the suppressed flag when deactive a framework.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> d541bfa3f4190865c65d35c9d1ffdb8a3f194056 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
> 
> Diff: https://reviews.apache.org/r/39628/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04
> make 
> make check
> GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to