-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114672
-----------------------------------------------------------

Ship it!


Very nice! I'll make some minor adjustments based on the comments and get this 
committed for you.


src/tests/master_tests.cpp (lines 3921 - 3939)
<https://reviews.apache.org/r/42212/#comment175538>

    I tried to consolidate these comments by pulling down the parts of the test 
level comment into the test body:
    
    ```
    // Test the max_completed_framework flag for master.
    TEST_F(MasterTest, MaxCompletedTasksPerFrameworkFlag)
    {
      // In order to verify that the proper amount of history
      // is maintained, we launch exactly 2 frameworks when
      // 'max_completed_frameworks' is set to 0, 1 and 2. This
      // covers the cases of maintaining 0 history, some history
      // less than the total number of frameworks launched, and
      // history equal to the total number of frameworks launched.
      const size_t totalFrameworks = 2;
      const size_t maxFrameworksArray[] = {0, 1, 2};
    ```



src/tests/master_tests.cpp (lines 3993 - 4011)
<https://reviews.apache.org/r/42212/#comment175539>

    Tried to consolidate here as well:
    
    ```
    // Test the max_completed_tasks_per_framework flag for master.
    TEST_F(MasterTest, MaxCompletedTasksPerFrameworkFlag)
    {
      // We verify that the proper amount of history is maintained
      // by launching a single framework with exactly 2 tasks. We
      // do this when setting `max_completed_tasks_per_framework`
      // to 0, 1, and 2. This covers the cases of maintaining no
      // history, some history less than the total number of tasks
      // launched, and history equal to the total number of tasks
      // launched.
      const size_t totalTasksPerFramework = 2;
      const size_t maxTasksPerFrameworkArray[] = {0, 1, 2};
    ```



src/tests/master_tests.cpp (line 4011)
<https://reviews.apache.org/r/42212/#comment175535>

    whoops: s/{ /{/



src/tests/master_tests.cpp (line 4085)
<https://reviews.apache.org/r/42212/#comment175537>

    Perhaps:
    
    ```
    // There should be only 1 completed framework.
    ```
    
    Specifically, not sure if we need to describe that we "count" here?


- Ben Mahler


On Jan. 15, 2016, 12:49 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
>     https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> -------
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to