-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42246/#review114736
-----------------------------------------------------------

Ship it!



src/hdfs/hdfs.cpp (line 313)
<https://reviews.apache.org/r/42246/#comment175591>

    +1 on update the comments.
    
    I would suggest we also rename this method to 'normalize'.
    
    Plus, this method does not need to be a member function. Can you make it a 
file local helper? I.e.,
    
    ```
    // Normalize an HDFS path such that it is either an absolute
    // path or a full hdfs:// URL.
    static string normalize(const string& hdfsPath)
    {
      ...
    }
    ```



src/hdfs/hdfs.cpp (line 315)
<https://reviews.apache.org/r/42246/#comment175594>

    This is a fine workaround at the current moment. Please add a NOTE here 
saying that the URLs for all protocols suppported by HDFS client contains "://".


- Jie Yu


On Jan. 13, 2016, 10:07 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42246/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 10:07 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-4304
>     https://issues.apache.org/jira/browse/MESOS-4304
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed support for non-HDFS URIs by Hadoop client.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e 
> 
> Diff: https://reviews.apache.org/r/42246/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to