----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41937/#review114759 -----------------------------------------------------------
I still don't like the fact that we are taking a generic helper function and forcing people to create json to be able to use it. Let's move ahead with the protobuf wrapper approach we discussed with benh. I think this will allow us to have a more useful argument to this helper function. - Joris Van Remoortere On Jan. 12, 2016, 9:32 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41937/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 9:32 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-4058 > https://issues.apache.org/jira/browse/MESOS-4058 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/quota_handler.cpp 134a93b1d1b6e050aa8a5037ffbec2cc305b0694 > > Diff: https://reviews.apache.org/r/41937/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.5 > > > Thanks, > > Alexander Rukletsov > >
