-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42277/#review114818
-----------------------------------------------------------

Ship it!



src/linux/fs.hpp (line 343)
<https://reviews.apache.org/r/42277/#comment175664>

    can you use 'unmountAll' here? Not sure why we used snake case for 
'pivor_root'.



src/linux/fs.cpp (line 350)
<https://reviews.apache.org/r/42277/#comment175667>

    No need for std:: prefix here. Can you add
    ```
    using std::vector
    ```
    
    and remove the std::prefix here?



src/linux/fs.cpp (line 352)
<https://reviews.apache.org/r/42277/#comment175665>

    can we add a 'reverse_foreach' in stout?


- Jie Yu


On Jan. 14, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42277/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add mount_all to linux fs.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp 76c72930724b882d3b74edb3a91d5988fcbfc2ed 
>   src/linux/fs.cpp bfcf97186cd1b0696a9537c4a332083def6b462e 
> 
> Diff: https://reviews.apache.org/r/42277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to