----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review114891 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 201) <https://reviews.apache.org/r/42386/#comment175723> Should be "bool", not "const bool&". - Neil Conway On Jan. 16, 2016, 5 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42386/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2016, 5 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > The function of `createFrameworkInfo` was updated by enabling > caller can set a bool parameter to create a framework which can > use revocable resources. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 9362dd306497ba01e0f387c3862456cdcac6f863 > > Diff: https://reviews.apache.org/r/42386/diff/ > > > Testing > ------- > > make > make tests > GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" > --verbose > > > Thanks, > > Guangya Liu > >
