> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, line 575
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line575>
> >
> >     Should we take `strings::tokenize(tokens[1], ",")` out and check its 
> > size?

Nope. the contains check below will handle the error case.


> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, lines 576-581
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line576>
> >
> >     Do we allow any of `"xxx", "yyy", "zzz"` to be empty? If not, it may be 
> > more safe to use `strings::tokenize`.

It doesn't matter. It'll be an error anyway.


> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, lines 598-601
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line598>
> >
> >     Should we handle removing quotation marks here?

Nope. The quotes have been removed above. I added a TODO about query encoding.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114758
-----------------------------------------------------------


On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the Docker URI fetcher plugin based on curl.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf 
> 
> Diff: https://reviews.apache.org/r/42238/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to