----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/#review115079 -----------------------------------------------------------
Patch looks great! Reviews applied: [42265] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 18, 2016, 9:58 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42265/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9:58 p.m.) > > > Review request for mesos, Joris Van Remoortere and Timothy Chen. > > > Bugs: MESOS-4349 > https://issues.apache.org/jira/browse/MESOS-4349 > > > Repository: mesos > > > Description > ------- > > Specifically, the following tests: > > MasterTest.OfferNotRescindedOnceUsed > OversubscriptionTest.FetchResourceUsageFromMonitor > OversubscriptionTest.QoSFetchResourceUsageFromMonitor > SlaveTest.ContainerUpdatedBeforeTaskReachesExecutor > > > Diffs > ----- > > src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3 > src/tests/oversubscription_tests.cpp > 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a > src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 > > Diff: https://reviews.apache.org/r/42265/diff/ > > > Testing > ------- > > Ran each test a few hundred times with and without the changes; without the > changes, a warning is observed. With the changes, no warning is observed. > > > Thanks, > > Neil Conway > >
