-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42289/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:10 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, Joris Van
Remoortere, and Neil Conway.
Changes
-------
Repeated test done for allocator.
Bugs: MESOS-4102
https://issues.apache.org/jira/browse/MESOS-4102
Repository: mesos
Description
-------
__Phenomenon__:
Quota doesn't allocate resources on slave joining.
__Root Cause__:
Event-triggered allocations do not include all available agents. If we
calculate remaining resources in the cluster using the partial view,
we may overlook already laid away resources for quota'ed roles and lay
away more. Hence we may unnecessarily deprive non-quota'ed frameworks
of resources.
Refer to AlexR's comments for more detail:
https://issues.apache.org/jira/browse/MESOS-4102?focusedCommentId=15048495&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15048495
__Solution/Fix__:
Calcuated 'remainingClusterResources' by all activated slaves.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp
48acde69b1a2f305b568a7e322a58708063dd30a
src/tests/hierarchical_allocator_tests.cpp
9362dd306497ba01e0f387c3862456cdcac6f863
Diff: https://reviews.apache.org/r/42289/diff/
Testing (updated)
-------
make
make check
./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose
--gtest_repeat=100 --gtest_shuffle
Thanks,
Klaus Ma
