> On Jan. 17, 2016, 10:37 a.m., Artem Harutyunyan wrote:
> > We avoid making changes in 3rdparty and the Mesos code within the same 
> > patch. Could you please break this patch into 2?
> 
> Qian Zhang wrote:
>     Did you mean splitting the commit between mesos and libprocess? I saw we 
> have a check in the pre-commit (see the link below) which ensures we should 
> not have the code changes for Mesos and libprocess in the same patch, that's 
> why I have two commit: this one and https://reviews.apache.org/r/42069/, 
> please let me know if you have further comments.
>     https://github.com/apache/mesos/blob/0.26.0/support/hooks/pre-commit#L29

There's isn't a pre-commit hook for everything in 3rdparty, but it would be 
good to separate:
3rdparty/leveldb.patch
3rdparty/zookeeper-3.4.5.patch

---

src/linux/fs.cpp


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42068/#review114910
-----------------------------------------------------------


On Jan. 17, 2016, 5:51 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42068/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4312
>     https://issues.apache.org/jira/browse/MESOS-4312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Porting Mesos on ppc64le.
> 
> 
> Diffs
> -----
> 
>   3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   src/linux/fs.cpp bfcf97186cd1b0696a9537c4a332083def6b462e 
> 
> Diff: https://reviews.apache.org/r/42068/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX 10.10.5, Ubuntu 14.04.3 LTS ppc64le)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to