-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41769/#review115232
-----------------------------------------------------------


The central part lgtm, will check the tests tomorrow morning in more detail.


src/tests/hierarchical_allocator_tests.cpp (line 1855)
<https://reviews.apache.org/r/41769/#comment176138>

    s/0;/0



src/tests/hierarchical_allocator_tests.cpp (line 1900)
<https://reviews.apache.org/r/41769/#comment176136>

    s/0;/0



src/tests/hierarchical_allocator_tests.cpp (line 1901)
<https://reviews.apache.org/r/41769/#comment176135>

    s/0;/0



src/tests/hierarchical_allocator_tests.cpp (line 1903)
<https://reviews.apache.org/r/41769/#comment176137>

    it 10 times smaller only for mem



src/tests/hierarchical_allocator_tests.cpp (line 1934)
<https://reviews.apache.org/r/41769/#comment176134>

    s/2048;/2048


he

- Joerg Schad


On Jan. 19, 2016, 12:38 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41769/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 12:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Klaus 
> Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-4411
>     https://issues.apache.org/jira/browse/MESOS-4411
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch include two parts:
> 1) If there are some non-active roles in front of active roles after 
> quotaRoleSorter, when the allocator encounter a non-active role, the 
> allocator should not break but continue to allocate Quota for other active 
> roles to make sure other roles can get its quotaed resources.
> 2) If some role's quota reach its guaranteed value, the allocator should 
> handle another role but not break. Take the following case: role1 has quota 5 
> and got 5, role2 has quota 100 and got 50, the role1 will be put in front of 
> role2 by the quotaRoleSorter, if allocator break when found role1 is 
> satisfied, then role2 will never get its quotaed resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 48acde69b1a2f305b568a7e322a58708063dd30a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/41769/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> GLOG_v=2  ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose --gtest_repeat=100 --gtest_shuffle
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to