-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115267
-----------------------------------------------------------



src/slave/paths.hpp (lines 269 - 273)
<https://reviews.apache.org/r/42472/#comment176214>

    I would prefer keep paths functions as simple as possible and rely on the 
caller to properly pass in the correct 'rootDir'.


- Jie Yu


On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4400
>     https://issues.apache.org/jira/browse/MESOS-4400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8 
>   src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c 
>   src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 
>   src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a 
> 
> Diff: https://reviews.apache.org/r/42472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to