----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115268 -----------------------------------------------------------
src/slave/slave.cpp (line 360) <https://reviews.apache.org/r/42474/#comment176223> you can do `resources->filter(...)` src/slave/slave.cpp (lines 364 - 365) <https://reviews.apache.org/r/42474/#comment176220> Can we use EXIT(1) instead of CHECK here so that it's less confusing to operators. - Jie Yu On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42474/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9:23 p.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-4403 > https://issues.apache.org/jira/browse/MESOS-4403 > > > Repository: mesos > > > Description > ------- > > Create disk paths based on 'DiskInfo.Source' if the type is 'PATH' > and the directory does not yet exist. > > > Diffs > ----- > > src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 > > Diff: https://reviews.apache.org/r/42474/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
