-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42355/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 11:32 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Summary (updated)
-----------------
Removed the timeout from the filter.
Bugs: MESOS-4302
https://issues.apache.org/jira/browse/MESOS-4302
Repository: mesos
Description (updated)
-------
Without the timeout, we rely on filter expiration only. This guarantees
that filter removal is scheduled after `allocate()` if the allocator is
backlogged given default parameters are used. Additionally we ensure the
filter timeout is at least as big as the allocation interval.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp
48acde69b1a2f305b568a7e322a58708063dd30a
src/tests/hierarchical_allocator_tests.cpp
9362dd306497ba01e0f387c3862456cdcac6f863
Diff: https://reviews.apache.org/r/42355/diff/
Testing (updated)
-------
On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="HierarchicalAllocatorTest.FilterTimeout" ./bin/mesos-tests.sh
--gtest_repeat=100 --gtest_break_on_failure` passes with the patch and fails
without.
`GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh
--gtest_repeat=100 --gtest_break_on_failure`
Thanks,
Alexander Rukletsov
