-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/#review115283
-----------------------------------------------------------

Ship it!



src/tests/reservation_tests.cpp (lines 1761 - 1762)
<https://reviews.apache.org/r/42361/#comment176239>

    We still should set the `role` explicitly right?
    
    `DEFAULT_FRAMEWORK_INFO` doesn't include a `role`.



src/tests/reservation_tests.cpp (line 1786)
<https://reviews.apache.org/r/42361/#comment176240>

    Can we be more specific in that this is a `ReservationInfo` with a missing 
principal, rather than just an empty `ReservationInfo`?


- Michael Park


On Jan. 19, 2016, 11:40 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42361/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4195
>     https://issues.apache.org/jira/browse/MESOS-4195
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added dynamic reservation test with no principal.
> 
> Currently, we do not allow dynamic reservations without a principal. This 
> test was added to verify that framework reserve operations without a 
> principal will fail as expected.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/42361/diff/
> 
> 
> Testing
> -------
> 
> A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and 
> `make check` was used to test. The new test was also run with 
> `--gtest_repeat=1000 --gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to