-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42124/#review115288
-----------------------------------------------------------


You may want to revisit this patch in light of the recent /state jsonify 
changes.


src/common/http.cpp (lines 126 - 143)
<https://reviews.apache.org/r/42124/#comment176248>

    Note: This only affects the agent now.  You'll need to modify the jsonify 
version so that it shows up in the master.
    
    You should ask [~mcypark] if there are plans to fully replace the various 
`model` functions.


- Joseph Wu


On Jan. 16, 2016, 12:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42124/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4327
>     https://issues.apache.org/jira/browse/MESOS-4327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated /state to show usage slack and allocation slack resources.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
> 
> Diff: https://reviews.apache.org/r/42124/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from HTTPTest
> [ RUN      ] HTTPTest.ModelResources
> I0111 11:06:26.616374 1928241920 resources.cpp:513] Parsing resources as JSON 
> failed: cpus:1;cpus(foo):1;mem:512;disk:1024;ports(foo):[1-10];bar:1
> Trying semicolon-delimited string format instead
> [       OK ] HTTPTest.ModelResources (2 ms)
> [----------] 1 test from HTTPTest (2 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (12 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to