----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/#review115310 -----------------------------------------------------------
src/tests/mesos.hpp (line 479) <https://reviews.apache.org/r/42530/#comment176280> Oops, sorry. Let's give this a default argument of `None()` here for consistently in style and so that we can do `createReservationInfo()`. - Michael Park On Jan. 20, 2016, 1:30 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42530/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 1:30 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Changed `createReservationInfo` to take `Option<string>`. > > > Diffs > ----- > > src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac > > Diff: https://reviews.apache.org/r/42530/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >