----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42252/#review115339 -----------------------------------------------------------
src/master/master.cpp (line 4659) <https://reviews.apache.org/r/42252/#comment176308> It checked Optimistic Offer Phase 1 is enabled in https://reviews.apache.org/r/41847/. But I think it's not necessary. Checking the flag at `addSlave`, `updateAllocation` and `updateAvailable` in enough. In other place, we just need to handle the case that `allocationSlack` is empty; this case is also true when flag is enable by no `statless.reserved` resources. Update test on `allocationSlack` in `totalResource`. - Klaus Ma On Jan. 13, 2016, 10:37 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42252/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 10:37 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4321 > https://issues.apache.org/jira/browse/MESOS-4321 > > > Repository: mesos > > > Description > ------- > > After master call updateSlave, the totalResources do not include > allocation resources, this will cause some problem when end user > using /state endpoint to check resources status. > > > Diffs > ----- > > src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 > > Diff: https://reviews.apache.org/r/42252/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
