----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42556/ -----------------------------------------------------------
Review request for mesos and Jie Yu. Repository: mesos Description ------- Currently image validation is done assuming that the image's filename will have digest (SHA-512) information. This is not part of the spec (https://github.com/appc/spec/blob/master/spec/discovery.md). The spec specifies the tuple <image name, labels> as unique identifier for discovering an image. This change add the necessary function to derive the image's file name and adds validation before creating a CachedImage. Diffs ----- src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION src/slave/containerizer/mesos/provisioner/appc/spec.hpp d4fd8cbfd5668da9ce4ac86baaadf42945c5abbd src/slave/containerizer/mesos/provisioner/appc/spec.cpp 324cdfec3766da4a8e324378a6e413477fa2b5d9 Diff: https://reviews.apache.org/r/42556/diff/ Testing ------- make check. Thanks, Jojy Varghese
