-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115863
-----------------------------------------------------------



src/common/resources.cpp (line 310)
<https://reviews.apache.org/r/42471/#comment176923>

    This is not correct. You've already checked left.disk() == right.disk(), 
why do you need this? Instead, you should check if left != right:
    
    ```
    if (left.disk().has_source() &&
        left.disk().source().type() == MOUNT &&
        left != right) {
      return false;
    }
    ```



src/v1/resources.cpp (lines 308 - 310)
<https://reviews.apache.org/r/42471/#comment176924>

    Ditto.


- Jie Yu


On Jan. 22, 2016, 9:27 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 9:27 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4380
>     https://issues.apache.org/jira/browse/MESOS-4380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a 
>   include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726 
>   src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/42471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to