----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/#review115898 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 68) <https://reviews.apache.org/r/42506/#comment176953> '{' in next line. src/tests/persistent_volume_tests.cpp (line 72) <https://reviews.apache.org/r/42506/#comment176948> 2 lines apart please. src/tests/persistent_volume_tests.cpp (line 80) <https://reviews.apache.org/r/42506/#comment176956> I think you can use environment->mkdtemp() so that you don't need to worry about teardown. src/tests/persistent_volume_tests.cpp (line 81) <https://reviews.apache.org/r/42506/#comment176958> We try to avoid CHECK in test since it'll abort the entire test run. Can you de ASSERT instead? src/tests/persistent_volume_tests.cpp (line 150) <https://reviews.apache.org/r/42506/#comment176949> '{' in next line. src/tests/persistent_volume_tests.cpp (lines 150 - 167) <https://reviews.apache.org/r/42506/#comment176951> Do you still need this? Can you just use paths::getPersistentVolumePath? src/tests/persistent_volume_tests.cpp (line 170) <https://reviews.apache.org/r/42506/#comment176960> Do you still need this? - Jie Yu On Jan. 22, 2016, 9:33 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42506/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 9:33 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Repository: mesos > > > Description > ------- > > This allows us to leverage the existing persistent volume tests while > also testing support for multiple disks. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 7acf7ab29d64d891f3288f8042d267dcc82a32e9 > > Diff: https://reviews.apache.org/r/42506/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
