-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review115991
-----------------------------------------------------------




src/tests/persistent_volume_tests.cpp (line 90)
<https://reviews.apache.org/r/42684/#comment177028>

    Add a new line above.



src/tests/persistent_volume_tests.cpp (line 92)
<https://reviews.apache.org/r/42684/#comment177029>

    add a new line above



src/tests/persistent_volume_tests.cpp (lines 97 - 110)
<https://reviews.apache.org/r/42684/#comment177027>

    Hum, this looks a little hacky to me. /sys/fs/cgroup is a tmpfs as well. 
Are we going to write random file in it?
    
    We can mount a tmpfs to diskPath (but we need to clean it up in TearDown).



src/tests/persistent_volume_tests.cpp (line 141)
<https://reviews.apache.org/r/42684/#comment177030>

    Can you add a comment here explaining what 'number' is? Also, I prefer to 
call it 'name' like 'disk1', 'disk2', etc.


- Jie Yu


On Jan. 23, 2016, 10:57 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> 7acf7ab29d64d891f3288f8042d267dcc82a32e9 
>   src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to