-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review116062
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/quota/quota.proto (line 56)
<https://reviews.apache.org/r/42476/#comment177078>

    I don't get the `16` as per Joerg's comment.



src/master/quota_handler.cpp (lines 67 - 68)
<https://reviews.apache.org/r/42476/#comment177076>

    Please keep this function a general use one. Users of it should not need to 
create a `QuotaRequest` in order to construct a `QuotaInfo`.



src/master/quota_handler.cpp (line 68)
<https://reviews.apache.org/r/42476/#comment177077>

    Can you augment the `QuotaInfo` validation function with the new role 
validation introduced?


- Joris Van Remoortere


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
>     https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to