> On Jan. 26, 2016, 12:28 a.m., Benjamin Bannier wrote: > > Was any of this confirm by profiling? In standard C++ there is an > > overloaded `operator==` for `std::string` which can compare with a `const > > char*`.
Yes confirmed by profiler. It it constructing the strings per iteration. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42762/#review116231 ----------------------------------------------------------- On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42762/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 12:10 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > This validation is used inside resource math which in turn is used > heavily in the code base. > The temporary string allocations caused a significant performance > degradation in this critical path. > > > Diffs > ----- > > src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846 > > Diff: https://reviews.apache.org/r/42762/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
