> On Jan. 25, 2016, 8:43 a.m., Bernd Mathiske wrote: > > src/tests/health_check_tests.cpp, line 351 > > <https://reviews.apache.org/r/42674/diff/2/?file=1218677#file1218677line351> > > > > Instead of naked strings we should reuse a constant that we can change > > in one place.
I think I'll punt on this for now. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116064 ----------------------------------------------------------- On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Replaced busybox with alpine in docker tests. > Busybox is currently causing issues with Docker daemon with btrfs backed > (https://github.com/docker/docker/issues/16755), which is the default on > CentOS 7. Docker daemon is reporting too many routes/links after downloading > busybox, which is exactly the issue referred in the previous link. > Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 81ab3625a69644d9659d484f3c605aaa5a10b397 > src/tests/containerizer/docker_tests.cpp > 9583070d64e96f5a57db62b3fb69073ecc5b502b > src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42674/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
