-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review116304
-----------------------------------------------------------




src/tests/reservation_endpoints_tests.cpp (line 782)
<https://reviews.apache.org/r/42754/#comment177356>

    why does the offerResources contain the labeledResources2? The 
labeledResources2 should be filtered when allocate?



src/tests/resources_tests.cpp (line 833)
<https://reviews.apache.org/r/42754/#comment177340>

    s/dynamic reservation./dynamic reservation without labels.



src/tests/resources_tests.cpp (line 839)
<https://reviews.apache.org/r/42754/#comment177342>

    s/dynamic reservation, and labels./dynamic reservation with labels.



src/tests/resources_tests.cpp (line 1592)
<https://reviews.apache.org/r/42754/#comment177344>

    s/Dynamically reserved./Dynamically reserved without labels.



src/tests/resources_tests.cpp (line 1666)
<https://reviews.apache.org/r/42754/#comment177349>

    Can you please add more test cases to make two reservations with different 
labels and validate that they are not addable?



src/tests/resources_tests.cpp (lines 1687 - 1689)
<https://reviews.apache.org/r/42754/#comment177350>

    Can you please add a new test cases named as `SubtractionWithLabels` to 
validate subtractable and nont subtractable?


- Guangya Liu


On 一月 25, 2016, 11:02 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> -----------------------------------------------------------
> 
> (Updated 一月 25, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
>     https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/tests/mesos.hpp 5a737a6490060b0194db097990b327c9921221f4 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
>   src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to