> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote: > > src/tests/disk_quota_tests.cpp, lines 132-133 > > <https://reviews.apache.org/r/41818/diff/4/?file=1195105#file1195105line132> > > > > Can you add a simple DiskUsageCollectorTest here to test the exclude > > path?
`du` excludes symlinks anyway, so what exactly do we want to test here? - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116224 ----------------------------------------------------------- On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41818/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 12:13 a.m.) > > > Review request for Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4281 > https://issues.apache.org/jira/browse/MESOS-4281 > > > Repository: mesos > > > Description > ------- > > Handled quota when volumes are bind mounted into the sandbox. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/posix/disk.hpp > 31808c1e8199fbf2cea36c273860fdbf0a2388f8 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 248c34adb63907911d89bed5b1519682a852bb2d > src/tests/containerizer/filesystem_isolator_tests.cpp > 5bb85034c22caef64054c1629f6fd55d227e48b1 > src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 > > Diff: https://reviews.apache.org/r/41818/diff/ > > > Testing > ------- > > sudo mesos-tests.sh > > > Thanks, > > Artem Harutyunyan > >
