-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42789/#review116436
-----------------------------------------------------------




support/endpoint-docs.cpp (line 80)
<https://reviews.apache.org/r/42789/#comment177449>

    Should probably add `using std::string;`



support/endpoint-docs.cpp (line 86)
<https://reviews.apache.org/r/42789/#comment177447>

    Typo in comment.



support/endpoint-docs.cpp (line 87)
<https://reviews.apache.org/r/42789/#comment177454>

    Comment should end in a period.



support/endpoint-docs.cpp (line 103)
<https://reviews.apache.org/r/42789/#comment177462>

    Better to use `foreach` or a range-based `for`, probably.



support/endpoint-docs.cpp (line 150)
<https://reviews.apache.org/r/42789/#comment177460>

    Typo



support/endpoint-docs.cpp (line 160)
<https://reviews.apache.org/r/42789/#comment177461>

    This comment is confusing.



support/endpoint-docs.cpp (line 177)
<https://reviews.apache.org/r/42789/#comment177463>

    If the string's length is < 5 characters, seems like this would overflow 
and throw an exception.



support/endpoint-docs.cpp (line 251)
<https://reviews.apache.org/r/42789/#comment177453>

    Comment should end in a period.



support/endpoint-docs.cpp (line 267)
<https://reviews.apache.org/r/42789/#comment177452>

    Comment should end in a period.



support/endpoint-docs.cpp (line 328)
<https://reviews.apache.org/r/42789/#comment177451>

    Comment should end in a period.



support/endpoint-docs.cpp (line 383)
<https://reviews.apache.org/r/42789/#comment177450>

    Comment should end in a period.


- Neil Conway


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42789/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After building mesos from source, an executable called
> mesos-endpoint-docs will be created in build/src. Invoke this executable
> with the flag --dirname=../docs/endpoints to autogenerate documentation
> for all endpoint strings and install it into the proper location.  In a
> subsequent commit we will add a link to this directory in home.md.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   support/endpoint-docs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42789/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to