-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/#review116447
-----------------------------------------------------------



Bad patch!

Reviews applied: [39850, 39851, 39852, 39888, 39889, 40102, 40851]

Failed command: ./support/apply-review.sh -n -r 40851

Error:
 ...<truncated>...
2016-01-26 20:47:03 URL:https://reviews.apache.org/r/40851/diff/raw/ 
[27690/27690] -> "40851.patch" [1]
40851.patch:211: trailing whitespace.
 
40851.patch:286: trailing whitespace.
-        lock xadd dword ptr [eax], ecx; 
40851.patch:287: trailing whitespace.
-       lock xadd dword ptr [eax], ebx; 
40851.patch:288: trailing whitespace.
-        mov result, ecx; // result = ebx;        
40851.patch:290: trailing whitespace.
-     return result;    
warning: 5 lines add whitespace errors.
3rdparty/zookeeper-3.4.5.patch:202: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:277: trailing whitespace.
+-        lock xadd dword ptr [eax], ecx; 
3rdparty/zookeeper-3.4.5.patch:278: trailing whitespace.
+-       lock xadd dword ptr [eax], ebx; 
3rdparty/zookeeper-3.4.5.patch:279: trailing whitespace.
+-        mov result, ecx; // result = ebx;        
3rdparty/zookeeper-3.4.5.patch:281: trailing whitespace.
+-     return result;    

Full log: https://builds.apache.org/job/mesos-reviewbot/11058/console

- Mesos ReviewBot


On Jan. 26, 2016, 8:18 p.m., M Lawindi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40851/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex 
> Clemmer, and M Lawindi.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
> 
> Diff: https://reviews.apache.org/r/40851/diff/
> 
> 
> Testing
> -------
> 
> - Applied patch to original zookeeper 3.4.5
> - Successfully opened 2015 solution in VS2015
> - Cli and Zookeeper build successfully
> 
> 
> Thanks,
> 
> M Lawindi
> 
>

Reply via email to