-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review116503
-----------------------------------------------------------


Fix it, then Ship it!




Based on how we'd like to address the floating point behavior in the 
short-term, this will be a useful test to add.


src/tests/reservation_tests.cpp (line 173)
<https://reviews.apache.org/r/40731/#comment177518>

    Whitespace.



src/tests/reservation_tests.cpp (line 181)
<https://reviews.apache.org/r/40731/#comment177516>

    This shouldn't be necessary now that we have implicit roles.


- Neil Conway


On Jan. 20, 2016, 6:08 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 6:08 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixture to test the floating point precision during CPU resource 
> allocation. This patch is based on the commit submitted by : Mandeep 
> (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to