-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/#review116512
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp (lines 1275 - 1281)
<https://reviews.apache.org/r/42836/#comment177529>

    Can we test to see what the perf is like if we were to do:
    
    ```cpp
    Resources remainingClusterResources = roleSorter->totalScalars();
    foreachkey (const string& role, activeRoles) {
      remainingClusterResources -= roleSorter->allocationScalars(role);
    }
    ```


- Michael Park


On Jan. 27, 2016, 1:16 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42836/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 1:16 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4505
>     https://issues.apache.org/jira/browse/MESOS-4505
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also used cached values from update sorter API.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42836/diff/
> 
> 
> Testing
> -------
> 
> make check
> callgrind with optimized build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to