> On Jan. 25, 2016, 7:51 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 48
> > <https://reviews.apache.org/r/42016/diff/2/?file=1192435#file1192435line48>
> >
> > The comment here seems like it could be clearer -- it's not actually
> > setting a directory, it's setting the environment variable that we use to
> > retrieve the tmp directory, right?
> >
> > I recommend just changing the code to something like the following
> > (NOTE: I have NOT tested this):
> >
> > ```
> > # Points at user temp directory, e.g.
> > `\Users\<user>\AppData\Local\Temp`.
> > set(USER_TMP_DIR $ENV{"TMP"})
> > ```
> >
> > This would simplify some of the logic below also, as well as making the
> > comment less confusing.
This is only setting the string "TMP"
The line after takes care of the environment variable use:
set(PATCHEXE_LOCATION $ENV{${USER_TMP_DIR}}/patch.exe)
- M
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42016/#review116138
-----------------------------------------------------------
On Jan. 27, 2016, 9:10 a.m., M Lawindi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42016/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 9:10 a.m.)
>
>
> Review request for Alex Naparu, Daniel Pravat, Alex Clemmer, M Lawindi, and
> Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows:[2/2] Added zookeeper-3.4.5 to Mesos build.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448
> 3rdparty/cmake/Mesos3rdpartyConfigure.cmake
> 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa
> 3rdparty/patch.exe.manifest PRE-CREATION
> src/slave/cmake/SlaveConfigure.cmake
> cf378a27297474b2a9f338e0c832612370f7302a
>
> Diff: https://reviews.apache.org/r/42016/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> M Lawindi
>
>
