----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review116609 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 219) <https://reviews.apache.org/r/41491/#comment177683> CHECK_LT(0u, image.layer_ids_size()); src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 238 - 244) <https://reviews.apache.org/r/41491/#comment177682> I think we already support parsing v1 manifest from string. No need for the JSON parsing part. src/tests/containerizer/provisioner_docker_tests.cpp (line 1255) <https://reviews.apache.org/r/41491/#comment177684> Can you add a TODO here. We need a helper to create test layers which will allow us to set manifest so that we can add checks here. - Jie Yu On Jan. 26, 2016, 5 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41491/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 5 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy > Chen. > > > Bugs: MESOS-4225 > https://issues.apache.org/jira/browse/MESOS-4225 > > > Repository: mesos > > > Description > ------- > > Exposed docker image manifest to mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 03425daaf015cf231920b7eda1d5424895a41286 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 4202f5552174ad3ab595ab3f16ab91d0854951f0 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 023f7363f33c4a927fae11037a408f6747fc3c39 > src/slave/containerizer/mesos/provisioner/store.hpp > aec725f789f7aeb92abfcc6718c2e6e2f1f37981 > src/tests/containerizer/provisioner_docker_tests.cpp > 33df60065903228749833bbad20449ba8784594a > > Diff: https://reviews.apache.org/r/41491/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
