> On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/common/command_utils.cpp, line 17 > > <https://reviews.apache.org/r/42662/diff/3/?file=1224149#file1224149line17> > > > > Move to line 28. > > Jojy Varghese wrote: > According to google style guide > (https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes), > the header file for an implementation should be included first. I thought we > follow google style guide unless something is overridden.
+1 > On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/common/command_utils.cpp, lines 91-92 > > <https://reviews.apache.org/r/42662/diff/3/?file=1224149#file1224149line91> > > > > Move to one line if less than 80. +1 > On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/tests/common/command_utils_tests.cpp, line 71 > > <https://reviews.apache.org/r/42662/diff/3/?file=1224150#file1224150line71> > > > > Add a case for `tar/untar` failure. > > Jojy Varghese wrote: > Will add a TODO. Maybe in a subsequent review. This patch is getting too big. @jojy, can you follow up with that? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116665 ----------------------------------------------------------- On Jan. 27, 2016, 8:29 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42662/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 8:29 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This common file is a good place to add common command line utilities like > tar, > digests(sha256, sha512, etc). Currently this functionality is spread in the > code > base and this change would enable all those call sites to be replaced with a > common code. > > > Diffs > ----- > > src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e > src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f > src/common/command_utils.hpp PRE-CREATION > src/common/command_utils.cpp PRE-CREATION > src/tests/common/command_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42662/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
