-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/#review116774
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/http.cpp (line 787)
<https://reviews.apache.org/r/42794/#comment177867>

    Please insert a newline before this line.



3rdparty/libprocess/src/tests/http_tests.cpp 
<https://reviews.apache.org/r/42794/#comment177868>

    Don't remove this line here.


- Jan Schlicht


On Jan. 27, 2016, 8:07 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42794/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Jan Schlicht.
> 
> 
> Bugs: MESOS-3317
>     https://issues.apache.org/jira/browse/MESOS-3317
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> URL query string order is defined.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 762da9a 
>   3rdparty/libprocess/src/tests/http_tests.cpp 66d185e 
> 
> Diff: https://reviews.apache.org/r/42794/diff/
> 
> 
> Testing
> -------
> 
> The following test cases in http_test.cpp have been modified -
> HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
> according alphabatic order.
> URLTest.Stringification to check generated query strings in URL to be 
> according alphabatic order.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to