> On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 1637 > > <https://reviews.apache.org/r/42554/diff/3/?file=1221040#file1221040line1637> > > > > hmmm .. we have generally just used `name` as the field-name at other > > places for specifying the image name in this file. What is different about > > this occurence? > > > > In a similar vein, `imageID` should just be `id`? > > Jie Yu wrote: > Anand, the reason is that we need to match the same in the following spec: > https://github.com/appc/spec/blob/master/spec/aci.md > > So that our json->protobuf parsing will work properly.
Gotcha, thanks! - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116823 ----------------------------------------------------------- On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42554/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 2:19 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added 'dependencies' message to AppcImageManifest. > > > Diffs > ----- > > include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b > > Diff: https://reviews.apache.org/r/42554/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
