----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116863 -----------------------------------------------------------
Fix it, then Ship it! I'll fix the remaining issue for you. src/common/command_utils.cpp (lines 178 - 179) <https://reviews.apache.org/r/42773/#comment177964> I would put these two in one line. src/common/command_utils.cpp (lines 191 - 197) <https://reviews.apache.org/r/42773/#comment177963> I would remove this check for now (will keep the TODO here). - Jie Yu On Jan. 29, 2016, 12:54 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42773/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 12:54 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Added utility function to compute SHA512 digest. > > > Diffs > ----- > > src/common/command_utils.hpp bfab34571dd37980d9f99585e506eb015b499e28 > src/common/command_utils.cpp e9d782127f948e165f55d03a2b1bf47946cc7f4e > src/tests/common/command_utils_tests.cpp > 938f3995aacf74bac28ae11040de292aa328f1e5 > > Diff: https://reviews.apache.org/r/42773/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
