-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42539/#review116869
-----------------------------------------------------------




src/launcher/executor.cpp (line 34)
<https://reviews.apache.org/r/42539/#comment177965>

    Should put this header file between
    ```
    #include <stout/flags.hpp>
    #include <stout/lambda.hpp>
    ```



src/launcher/executor.cpp (line 86)
<https://reviews.apache.org/r/42539/#comment177966>

    Should use taskCommand?



src/launcher/executor.cpp (line 99)
<https://reviews.apache.org/r/42539/#comment177967>

    Should be taskCommand?



src/launcher/executor.cpp (line 155)
<https://reviews.apache.org/r/42539/#comment177968>

    If meet error, should we skip following steps? Suppose both `json` and 
`protobuf` are failed. Seems continue to execute
    ```
    taskCommand = parse.get();
    ```
    not correct.


- haosdent huang


On Jan. 28, 2016, 8:28 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42539/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 8:28 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4004
>     https://issues.apache.org/jira/browse/MESOS-4004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support image specified Entrypoint and Cmd.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42539/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to