> On Jan. 28, 2016, 10:41 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp,
> > lines 41-55
> > <https://reviews.apache.org/r/40936/diff/6/?file=1197011#file1197011line41>
> >
> > I'm curious as to whether this struct is meant to be widely used aside
> > from `os::system`?
>
> Daniel Pravat wrote:
> These are just use for parameterss for shell in different place like
> lunch.cpp, test code.
Ok, how about we do the following?
```cpp
struct Shell {
static constexpr const char* name = "cmd.exe";
static constexpr const char* arg0 = "cmd.exe";
static constexpr const char* arg1 = "/c";
};
```
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40936/#review116751
-----------------------------------------------------------
On Jan. 29, 2016, 12:04 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40936/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 12:04 a.m.)
>
>
> Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Unified POSIX and Windows implementation of `shell.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp
> b18cae1118302e18d2cfb7ce4089ab5079a01d1a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp
> bf737c87b8a337cc46e6c16d6fec2eef61e6ea05
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
> 74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
> 061bb4a9b9efe4ddd364f589175446b07152c315
>
> Diff: https://reviews.apache.org/r/40936/diff/
>
>
> Testing
> -------
>
> OSX: make check
> Windows: Build
>
>
> Thanks,
>
> Daniel Pravat
>
>
