-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/#review117077
-----------------------------------------------------------


Ship it!




Thanks for fixing this debt!


3rdparty/libprocess/include/process/collect.hpp (lines 224 - 225)
<https://reviews.apache.org/r/42955/#comment178125>

    Newline here?
    
    Also, we tend to put the .then on a new line as if it was a statement, to 
make it clear that there's a continuation happening here:
    
    ```
    return collect(wrappers)
      .then(std::bind(f, futures...));
    ```


- Ben Mahler


On Jan. 30, 2016, 1:43 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42955/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
>     https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, templates only existed to allow collect to take either a
> std::list of Futures, or *exactly* 2 Futures as arguments.
> 
> This commit removes the 2 argument template and replaces it with a
> variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 
> 
> Diff: https://reviews.apache.org/r/42955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to