> On Jan. 30, 2016, 7:31 p.m., Joerg Schad wrote:
> > src/docker/executor.cpp, line 135
> > <https://reviews.apache.org/r/43015/diff/1/?file=1227124#file1227124line135>
> >
> >     I am not sure why we are printing this, but shouldn't we at least check 
> > for errors on os::shell?

Thought I alrady removed all of these, good catch.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review117116
-----------------------------------------------------------


On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to