----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/#review117131 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 151) <https://reviews.apache.org/r/43023/#comment178222> Not yours, but I think initializing this buffer to `{}` is not good style. (It suggests there might be code paths in which the buffer is not subsequently assigned to. If we leave it uninitialized, we get a compiler warning if we try to read from it before setting it, which is actually what we want.) 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 162) <https://reviews.apache.org/r/43023/#comment178224> I assume we have some evidence that this optimization is warranted? 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 173) <https://reviews.apache.org/r/43023/#comment178223> This seems a little more subtle than is warranted. - Neil Conway On Jan. 31, 2016, 12:06 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43023/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 12:06 a.m.) > > > Review request for mesos, Benjamin Hindman and Joris Van Remoortere. > > > Bugs: MESOS-4566 > https://issues.apache.org/jira/browse/MESOS-4566 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp > addec8ec6504e2a8f5b838fce3ebd4db224ab022 > > Diff: https://reviews.apache.org/r/43023/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >