> On Feb. 1, 2016, 9:03 a.m., Jian Qiu wrote:
> > src/master/master.hpp, line 1638
> > <https://reviews.apache.org/r/42594/diff/2/?file=1221350#file1221350line1638>
> >
> >     hashset<SlaveID>* slaveIDs, bool strict

Those parameters do not be used, so it does not need to name them.


> On Feb. 1, 2016, 9:03 a.m., Jian Qiu wrote:
> > src/master/master.hpp, line 1629
> > <https://reviews.apache.org/r/42594/diff/2/?file=1221350#file1221350line1629>
> >
> >     When to use readmit if framwork is not allowed to be updated

According to the original ideas, ReadmitFramework function will be called when 
framework re-register. If the registry do not mutated when framework 
re-register, then we can remove this function.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review117193
-----------------------------------------------------------


On Feb. 1, 2016, 7:24 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 7:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
> Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
>     https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to