----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/#review117428 -----------------------------------------------------------
So unfortunate that this didn't get into 0.27. We'll break the isolator interface again:( Can you update the upgrades.md and mention that change? Thanks! src/tests/containerizer/port_mapping_tests.cpp (line 692) <https://reviews.apache.org/r/43019/#comment178602> You forget this? Please do a grep to find all occurances. - Jie Yu On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43019/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 5:18 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Fixed non-camel case in protobuf field. > > > Diffs > ----- > > include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504 > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > 57168c837aabf85c85866ca9d4b5480f281e3143 > src/slave/containerizer/mesos/isolators/cgroups/mem.cpp > 34aa660204911ce4f22c7735af36c9f1af8b12b9 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 24ff8194bb5ea86a31224d2d2c20d367472168aa > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > 59ffd13920fb1c4fb8dbf04a2823d9cee75a8f27 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > d5dd93d892e3cde2011e208a050eec2b31891f54 > src/tests/containerizer/isolator_tests.cpp > 8d101df957fd36adac388310eddba2db1f98c029 > src/tests/containerizer/port_mapping_tests.cpp > 182fe9217a5da9af603d6f9c203a1689eff4ca1b > > Diff: https://reviews.apache.org/r/43019/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
