> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 440-443 > > <https://reviews.apache.org/r/42618/diff/3/?file=1227395#file1227395line440> > > > > Can you try to see if writing a decimal number if fine as well? If not, > > we should move the helper function into cpp as a file local helper.
Writing a decimal number works. Have moved this into a helper function in cgroups, as a separate patch. > On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 491-497 > > <https://reviews.apache.org/r/42618/diff/3/?file=1227395#file1227395line491> > > > > I don't think this is necessary. Agreed. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117243 ----------------------------------------------------------- On Feb. 2, 2016, 6:32 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42618/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 6:32 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42618/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
