----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43037/#review117453 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 96) <https://reviews.apache.org/r/43037/#comment178644> s/launchEnvironment/environment/ src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 108) <https://reviews.apache.org/r/43037/#comment178643> Ditto below. src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 110) <https://reviews.apache.org/r/43037/#comment178642> Should that be container_config? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 116 - 117) <https://reviews.apache.org/r/43037/#comment178637> I would prefer: ``` foreach(const string& env, containerConfig.docker().manifest().config().env()) { } ``` src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 122) <https://reviews.apache.org/r/43037/#comment178638> You want to print the containerId here as well. So i'll need to pass in the 'containerId' to this helper method. src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 126) <https://reviews.apache.org/r/43037/#comment178639> Add an extra line above. src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 137) <https://reviews.apache.org/r/43037/#comment178636> indentation. - Jie Yu On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43037/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 5:18 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4383 > https://issues.apache.org/jira/browse/MESOS-4383 > > > Repository: mesos > > > Description > ------- > > Support env var in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43037/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
