----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/#review117542 -----------------------------------------------------------
Patch looks great! Reviews applied: [42633, 42636, 42657, 42658, 42672, 41950, 42911, 43105] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 2, 2016, 11:13 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43105/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 11:13 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > If `addFramework()` is called before `addSlave()` double accounting > of resources is possible. We have not observed bugs because Mesos > currently always adds a framework in the allocator after all agents > with the framework's tasks have been added. > > > Diffs > ----- > > include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79 > src/master/allocator/mesos/hierarchical.cpp > 1a07d69016407e5aad2209586da37fecbcddb765 > > Diff: https://reviews.apache.org/r/43105/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
