----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/#review117565 -----------------------------------------------------------
Patch looks great! Reviews applied: [43124] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 3, 2016, 12:25 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43124/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 12:25 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4377 > https://issues.apache.org/jira/browse/MESOS-4377 > > > Repository: mesos > > > Description > ------- > > Note that I also removed an old TODO from `mesos.proto`: it has been partially > implemented, and in general the need for more first-class resource values is > well-known (e.g., many JIRAs on this topic). > > > Diffs > ----- > > docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 > include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 > include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed > > Diff: https://reviews.apache.org/r/43124/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >