> On Feb. 3, 2016, 5:34 p.m., Joerg Schad wrote:
> > src/tests/resources_tests.cpp, line 957
> > <https://reviews.apache.org/r/42751/diff/1/?file=1220217#file1220217line957>
> >
> >     I must say this pattern (distance(begin,end)) just to get the item 
> > count looks unintuitive here.
> >     I see that is currently the easiest way given Resources, but maybe it 
> > makes sense to add a count() or similar function to Resources (Not a real 
> > issue for me for this review).

Yeah, I agree it isn't ideal. I didn't want to change the `Resources` API just 
for a few test cases, but if other places would find the count useful, it would 
make sense to add support for it in a more intuitive way.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117635
-----------------------------------------------------------


On Jan. 25, 2016, 10:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to