-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review117671
-----------------------------------------------------------




src/CMakeLists.txt (line 239)
<https://reviews.apache.org/r/42557/#comment178946>

    Did you forget to update this patch. I saw it becomes cache.cpp in later 
patches.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 172)
<https://reviews.apache.org/r/42557/#comment178947>

    Hum, we don't usually sneak in changes like this in a 'move' patch. It'll 
be very to hard to review. Can you separate this change into a separate patch?


- Jie Yu


On Jan. 30, 2016, 2:06 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 2:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to